Add select to the list of default control elements in label-has-assoc…

…iated-control
jsx-eslint · Nov 18, 2018 · 6c33bcb · 6c33bcb
1 parent c0ca0b8
commit 6c33bcb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/__tests__/src/rules/label-has-associated-control-test.js b/__tests__/src/rules/label-has-associated-control-test.js
@@ -63,6 +63,7 @@ const bothValid = [
   { code: '<CustomLabel htmlFor="js_id" label="A label"><input /></CustomLabel>', options: [{ labelAttributes: ['label'], labelComponents: ['CustomLabel'] }] },
   // Custom label attributes.
   { code: '<label htmlFor="js_id" label="A label"><input /></label>', options: [{ labelAttributes: ['label'] }] },
+  { code: '<label htmlFor="selectInput">Some text<select id="selectInput" /></label>' },
 ];
 
 const alwaysValid = [

diff --git a/src/rules/label-has-associated-control.js b/src/rules/label-has-associated-control.js
@@ -57,7 +57,7 @@ module.exports = {
       if (componentNames.indexOf(elementType(node.openingElement)) === -1) {
         return;
       }
-      const controlComponents = ['input', 'textarea'].concat((options.controlComponents || []));
+      const controlComponents = ['input', 'select', 'textarea'].concat((options.controlComponents || []));
       // Prevent crazy recursion.
       const recursionDepth = Math.min(
         options.depth === undefined ? 2 : options.depth,