Fix test failures in role-has-required-aria-props due to ARIA 1.2 upd…

…ates
jsx-eslint · Jun 12, 2020 · b1f412a · b1f412a
1 parent 74cec6e
commit b1f412a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 28 deletions.
diff --git a/__tests__/src/rules/control-has-associated-label-test.js b/__tests__/src/rules/control-has-associated-label-test.js
@@ -192,7 +192,6 @@ const alwaysValid = [
   { code: '<div role="presentation" />' },
   { code: '<div role="region" />' },
   { code: '<div role="rowgroup" />' },
-  { code: '<div role="scrollbar" />' },
   { code: '<div role="search" />' },
   { code: '<div role="separator" />' },
   { code: '<div role="status" />' },
@@ -271,6 +270,7 @@ const neverValid = [
   { code: '<div role="progressbar" />', errors: [expectedError] },
   { code: '<div role="radio" />', errors: [expectedError] },
   { code: '<div role="rowheader" />', errors: [expectedError] },
+  { code: '<div role="scrollbar" />', errors: [expectedError] },
   { code: '<div role="searchbox" />', errors: [expectedError] },
   { code: '<div role="slider" />', errors: [expectedError] },
   { code: '<div role="spinbutton" />', errors: [expectedError] },

diff --git a/__tests__/src/rules/role-has-required-aria-props-test.js b/__tests__/src/rules/role-has-required-aria-props-test.js
@@ -70,33 +70,6 @@ ruleTester.run('role-has-required-aria-props', rule, {
       code: '<div role="slider" aria-valuemax aria-valuemin />',
       errors: [errorMessage('slider')],
     },
-    {
-      code: '<div role="slider" aria-valuemax aria-valuenow />',
-      errors: [errorMessage('slider')],
-    },
-    {
-      code: '<div role="slider" aria-valuemin aria-valuenow />',
-      errors: [errorMessage('slider')],
-    },
-
-    // SPINBUTTON
-    { code: '<div role="spinbutton" />', errors: [errorMessage('spinbutton')] },
-    {
-      code: '<div role="spinbutton" aria-valuemax />',
-      errors: [errorMessage('spinbutton')],
-    },
-    {
-      code: '<div role="spinbutton" aria-valuemax aria-valuemin />',
-      errors: [errorMessage('spinbutton')],
-    },
-    {
-      code: '<div role="spinbutton" aria-valuemax aria-valuenow />',
-      errors: [errorMessage('spinbutton')],
-    },
-    {
-      code: '<div role="spinbutton" aria-valuemin aria-valuenow />',
-      errors: [errorMessage('spinbutton')],
-    },
 
     // CHECKBOX
     { code: '<div role="checkbox" />', errors: [errorMessage('checkbox')] },