[Docs] anchor-is-valid: general cleanup
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- swap `div` for `span`, since `a` is an inline element.
ljharb
requested changes
Jul 14, 2020
docs/rules/anchor-is-valid.md
Outdated
Comment on lines
94
to
95
| > | ||
| onMouseEnter={() => this.setState({ showSomething: true })}>{label} |
There was a problem hiding this comment.
The main issue I wanted to address was the change from div to span. The formatting must have been my IDE setting, I thought it followed the project settings.
ljharb
approved these changes
Feb 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 98 98
Lines 1452 1452
Branches 477 477
=======================================
Hits 1441 1441
Misses 11 11 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed L48, the rest is just formatting.