Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate accessible-emoji rule #782

Merged

Conversation

backwardok
Copy link
Collaborator

The accessible-emoji rule got marked as deprecated to address #627, but was never removed from the rule set.

This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #782 (4b57a07) into master (8a0e43c) will not change coverage.
The diff coverage is n/a.

❗ Current head 4b57a07 differs from pull request most recent head ecec8e4. Consider uploading reports for the commit ecec8e4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1452     1452           
  Branches      477      477           
=======================================
  Hits         1441     1441           
  Misses         11       11           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0e43c...ecec8e4. Read the comment docs.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@ljharb ljharb requested a review from jessebeach March 25, 2021 06:02
@backwardok backwardok force-pushed the backwardok-fully-deprecate-emojis branch from 311eae5 to 5960043 Compare March 25, 2021 16:26
@backwardok
Copy link
Collaborator Author

@ljharb is there a way to retry a test or do I have to rebase and push again to trigger the tests to rerun?

@ljharb
Copy link
Member

ljharb commented Apr 5, 2021

@backwardok i think only a maintainer can retry one; otherwise the typical way is to close and reopen the PR. In this case, the task is failing because when rebased, there's merge conflicts. Feel free to ignore this tho; we can rebase it for you when it's ready to land.

@jessebeach

This comment has been minimized.

The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set.

This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
@ljharb ljharb force-pushed the backwardok-fully-deprecate-emojis branch from 4b57a07 to ecec8e4 Compare April 6, 2021 02:45
@ljharb ljharb merged commit ecec8e4 into jsx-eslint:master Apr 6, 2021
@backwardok backwardok deleted the backwardok-fully-deprecate-emojis branch April 6, 2021 17:29
@backwardok
Copy link
Collaborator Author

Thanks @ljharb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants