Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support img role for canvas. Fix for #648. #796

Merged
merged 1 commit into from Jun 13, 2021

Conversation

markwoon
Copy link
Contributor

@markwoon markwoon commented May 26, 2021

Tweaking recommendation for no-interactive-element-to-noninteractive-role to support img role on canvas.

Fixes #648.

@ljharb ljharb requested a review from jessebeach May 26, 2021 17:06
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but want to confirm with @jessebeach first

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #796 (55e5c11) into master (36102cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1453     1453           
  Branches      477      477           
=======================================
  Hits         1442     1442           
  Misses         11       11           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36102cd...55e5c11. Read the comment docs.

@jessebeach jessebeach merged commit 2ebb1ad into jsx-eslint:master Jun 13, 2021
@jessebeach
Copy link
Collaborator

Thanks @markwoon and @ljharb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsx-a11y/no-interactive-element-to-noninteractive-role for canvas
3 participants