Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-access-key wording and grammar #800

Merged
merged 7 commits into from Jul 13, 2021

Conversation

breadadams
Copy link
Contributor

@breadadams breadadams commented Jun 16, 2021

I spotted the "comments" typo in the error, and adjusted a couple of more things whilst addressing it 🙂

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #800 (952af25) into master (2ebb1ad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1453     1453           
  Branches      477      477           
=======================================
  Hits         1442     1442           
  Misses         11       11           
Impacted Files Coverage Δ
src/rules/no-access-key.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebb1ad...952af25. Read the comment docs.

@ljharb ljharb force-pushed the fix-no-access-key-grammar branch from 516e9f8 to 77422a8 Compare June 25, 2021 18:31
@ljharb ljharb force-pushed the fix-no-access-key-grammar branch from 77422a8 to 08e3258 Compare June 25, 2021 18:42
ljharb and others added 2 commits July 13, 2021 13:26
…rm-flow-strip-types`, `aud`, `eslint-plugin-flowtype`, `eslint-plugin-import`
@ljharb ljharb force-pushed the fix-no-access-key-grammar branch from 08e3258 to 927b5fb Compare July 13, 2021 20:26
@ljharb ljharb force-pushed the fix-no-access-key-grammar branch from 927b5fb to 1a17620 Compare July 13, 2021 21:21
@ljharb ljharb force-pushed the fix-no-access-key-grammar branch from 1a17620 to 952af25 Compare July 13, 2021 22:57
@ljharb ljharb merged commit 952af25 into jsx-eslint:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants