Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect wording in "no-access-key" error message #801

Closed
breadadams opened this issue Jun 25, 2021 · 1 comment
Closed

Incorrect wording in "no-access-key" error message #801

breadadams opened this issue Jun 25, 2021 · 1 comment

Comments

@breadadams
Copy link
Contributor

Recently noticed this on a project:

error  No access key attribute allowed. Inconsistencies between keyboard shortcuts and keyboard comments used by screenreader and keyboard only users create a11y complications  jsx-a11y/no-access-key

The mistake being the word "comments" instead of "commands".

(P.s. I already opened a PR for this here #800, however thought I'd follow the usual procedure 🙂)
@ljharb
Copy link
Member

ljharb commented Jun 25, 2021

Thanks! An issue isn't required; i'll take a look at the PR.

ljharb pushed a commit to breadadams/eslint-plugin-jsx-a11y that referenced this issue Jun 25, 2021
@breadadams @ljharb
[Fix] no-access-key: Fix wording and grammar
08e3258 
Fixes jsx-eslint#801.
ljharb pushed a commit to breadadams/eslint-plugin-jsx-a11y that referenced this issue Jul 13, 2021
@breadadams @ljharb
[Fix] no-access-key: Fix wording and grammar
927b5fb 
Fixes jsx-eslint#801.
ljharb pushed a commit to breadadams/eslint-plugin-jsx-a11y that referenced this issue Jul 13, 2021
@breadadams @ljharb
[Fix] no-access-key: Fix wording and grammar
1a17620 
Fixes jsx-eslint#801.
@ljharb ljharb closed this as completed in 952af25 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @breadadams