Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to 6.5.0 throw error #824

Closed
hellolovebuxiu opened this issue Nov 10, 2021 · 6 comments
Closed

upgrade to 6.5.0 throw error #824

hellolovebuxiu opened this issue Nov 10, 2021 · 6 comments

Comments

@hellolovebuxiu
Copy link

rule.create is not a function Occurred while linting
@hellolovebuxiu hellolovebuxiu changed the title upgrade to 6.5.0 broken upgrade to 6.5.0 throw error Nov 10, 2021
@martinpitt
Copy link

I see this in https://github.com/cockpit-project/cockpit-podman/ and other projects as well now:

ESLint: 7.32.0

TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function
Occurred while linting /var/home/martin/upstream/cockpit-podman/src/ContainerCheckpointModal.jsx
    at createRuleListeners (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:765:21)
    at /var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:937:31
    at Array.forEach (<anonymous>)
    at runRules (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:882:34)
    at Linter._verifyWithoutProcessors (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:1181:31)
    at Linter._verifyWithConfigArray (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:1280:21)
    at Linter.verify (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:1235:25)
    at Linter.verifyAndFix (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/linter/linter.js:1428:29)
    at verifyText (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/cli-engine/cli-engine.js:240:48)
    at CLIEngine.executeOnFiles (/var/home/martin/upstream/cockpit-podman/node_modules/eslint/lib/cli-engine/cli-engine.js:808:28)

martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Nov 10, 2021
@martinpitt
npm: Avoid broken eslint-plugin-jsx-a11y 6.5.0 version
7f7175b 
That latest version has a grave regression:

    TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function

Downgrade back to 6.4.1 for the time being.

See jsx-eslint/eslint-plugin-jsx-a11y#824
@martinpitt martinpitt mentioned this issue Nov 10, 2021
Merged
martinpitt added a commit to KKoukiou/cockpit-machines that referenced this issue Nov 10, 2021
@martinpitt
npm: Avoid broken eslint-plugin-jsx-a11y 6.5.0 version
4ed43ed 
That latest version has a grave regression:

    TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function

Downgrade back to 6.4.1 for the time being.

See jsx-eslint/eslint-plugin-jsx-a11y#824
@TomCorvus
Copy link

Hi there,
Same error for me since 6.5.0:

Oops! Something went wrong! :(

ESLint: 8.2.0

TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function

@avalenti89

This comment has been minimized.

Sign in to view
KKoukiou pushed a commit to cockpit-project/cockpit-podman that referenced this issue Nov 10, 2021
@martinpitt @KKoukiou
npm: Avoid broken eslint-plugin-jsx-a11y 6.5.0 version
195979e 
That latest version has a grave regression:

    TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function

Downgrade back to 6.4.1 for the time being.

See jsx-eslint/eslint-plugin-jsx-a11y#824
@ddolcimascolo

This comment has been minimized.

Sign in to view
KKoukiou pushed a commit to cockpit-project/cockpit-machines that referenced this issue Nov 10, 2021
@martinpitt @KKoukiou
npm: Avoid broken eslint-plugin-jsx-a11y 6.5.0 version
c082308 
That latest version has a grave regression:

    TypeError: Error while loading rule 'jsx-a11y/alt-text': rule.create is not a function

Downgrade back to 6.4.1 for the time being.

See jsx-eslint/eslint-plugin-jsx-a11y#824
@splincode splincode mentioned this issue Nov 10, 2021
Merged
11 tasks
@randombitsUK

This comment has been minimized.

Sign in to view
@ljharb
Copy link
Member

ljharb commented Nov 10, 2021

Yes thanks, this is why i unmarked it as “latest” last night, an hour or so after releasing it - so most people shouldn’t be prompted to update to it.

Downgrade to 6.4 for now; when I’ve fixed it I’ll publish a 6.5.1 and mark that as latest.

ljharb referenced this issue Nov 10, 2021
@ljharb
v6.5.0
f8c4001
This was referenced Nov 10, 2021
Closed
Merged
@ljharb ljharb closed this as completed in 8f7d0b0 Nov 10, 2021
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Nov 11, 2021
@martinpitt
npm: Update to latest eslint-plugin-jsx-a11y
77b7ca4 
Version 6.5.1 got released which works with ESLint 7 again and fixes
[1]. Bump the dependency. This essentially reverts the hack from
commit 195979e.

[1] jsx-eslint/eslint-plugin-jsx-a11y#824
@martinpitt martinpitt mentioned this issue Nov 11, 2021
Merged
martinpitt added a commit to martinpitt/cockpit-machines that referenced this issue Nov 11, 2021
@martinpitt
npm: Update to latest eslint-plugin-jsx-a11y
b479272 
Version 6.5.1 got released which works with ESLint 7 again and fixes
[1]. Bump the dependency. This essentially reverts the hack from
commit c082308.

[1] jsx-eslint/eslint-plugin-jsx-a11y#824
@martinpitt martinpitt mentioned this issue Nov 11, 2021
Merged
martinpitt added a commit to cockpit-project/cockpit-podman that referenced this issue Nov 11, 2021
@martinpitt
npm: Update to latest eslint-plugin-jsx-a11y
499a7df 
Version 6.5.1 got released which works with ESLint 7 again and fixes
[1]. Bump the dependency. This essentially reverts the hack from
commit 195979e.

[1] jsx-eslint/eslint-plugin-jsx-a11y#824
martinpitt added a commit to cockpit-project/cockpit-machines that referenced this issue Nov 11, 2021
@martinpitt
npm: Update to latest eslint-plugin-jsx-a11y
e526978 
Version 6.5.1 got released which works with ESLint 7 again and fixes
[1]. Bump the dependency. This essentially reverts the hack from
commit c082308.

[1] jsx-eslint/eslint-plugin-jsx-a11y#824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ljharb @martinpitt @TomCorvus @ddolcimascolo @randombitsUK @avalenti89 @hellolovebuxiu