Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-activedescendant-has-tabindex docs are outdated #924

Closed
dummdidumm opened this issue Feb 22, 2023 · 1 comment · Fixed by #925
Closed

aria-activedescendant-has-tabindex docs are outdated #924

dummdidumm opened this issue Feb 22, 2023 · 1 comment · Fixed by #925
Labels
documentation help wanted

Comments

@dummdidumm
Copy link
Contributor

https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/aria-activedescendant-has-tabindex.md says that a negative tabindex makes this rule fail. But that was updated in #708, but the docs generator likely wasn't run again for those docs.
@dummdidumm dummdidumm changed the title aria-activedescendant-has-tabindex are outdated aria-activedescendant-has-tabindex docs are outdated Feb 22, 2023
@ljharb
Copy link
Member

ljharb commented Feb 22, 2023

The docs generator doesn't handle most of the prose :-) a PR to fix the examples would be appreciated.

dummdidumm added a commit to dummdidumm/eslint-plugin-jsx-a11y that referenced this issue Feb 22, 2023
@dummdidumm
docs: update aria-activedescendant-has-tabindex.md
bd285bb 
align with changes from jsx-eslint#708
closes jsx-eslint#924
@dummdidumm dummdidumm mentioned this issue Feb 22, 2023
Merged
@ljharb ljharb closed this as completed in 7b3492b Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted
Projects
None yet
Milestone
No milestone
2 participants
@ljharb @dummdidumm