Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog links broken due to different repo #960

Closed
ColeFrench opened this issue Nov 3, 2023 · 1 comment
Closed

Changelog links broken due to different repo #960

ColeFrench opened this issue Nov 3, 2023 · 1 comment

Comments

@ColeFrench
Copy link

Hi @ljharb, it appears that the changelog is generated from your personal fork, ljharb/eslint-plugin-jsx-a11y, because all the links (to commits, tags, PRs, issues, etc.) are prefixed with that repo.

This breaks GitHub-specific things like PRs and issues, since they are only in this repository. Consider this excerpt from the update to v6.8.0 with all broken links:

Merged

  • Allow title attribute or aria-label attribute instead of accessible child in the "anchor-has-content" rule #727

Fixed

@ljharb
Copy link
Member

ljharb commented Nov 3, 2023

whoops, thanks, I’ll fix that.

@ljharb ljharb closed this as completed in 1635dcc Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants