/
require-render-return.js
193 lines (186 loc) · 4.32 KB
/
require-render-return.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
/**
* @fileoverview Enforce ES5 or ES6 class for returning value in render function.
* @author Mark Orel
*/
'use strict';
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------
const rule = require('../../../lib/rules/require-render-return');
const RuleTester = require('eslint').RuleTester;
const parserOptions = {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
jsx: true
}
};
// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------
const ruleTester = new RuleTester({parserOptions});
ruleTester.run('require-render-return', rule, {
valid: [{
// ES6 class
code: `
class Hello extends React.Component {
render() {
return <div>Hello {this.props.name}</div>;
}
}
`
}, {
// ES6 class with render property
code: `
class Hello extends React.Component {
render = () => {
return <div>Hello {this.props.name}</div>;
}
}
`,
parser: 'babel-eslint'
}, {
// ES6 class with render property (implicit return)
code: `
class Hello extends React.Component {
render = () => (
<div>Hello {this.props.name}</div>
)
}
`,
parser: 'babel-eslint'
}, {
// ES5 class
code: `
var Hello = createReactClass({
displayName: 'Hello',
render: function() {
return <div></div>
}
});
`
}, {
// Stateless function
code: `
function Hello() {
return <div></div>;
}
`
}, {
// Stateless arrow function
code: `
var Hello = () => (
<div></div>
);
`,
parser: 'babel-eslint'
}, {
// Return in a switch...case
code: `
var Hello = createReactClass({
render: function() {
switch (this.props.name) {
case 'Foo':
return <div>Hello Foo</div>;
default:
return <div>Hello {this.props.name}</div>;
}
}
});
`
}, {
// Return in a if...else
code: `
var Hello = createReactClass({
render: function() {
if (this.props.name === 'Foo') {
return <div>Hello Foo</div>;
} else {
return <div>Hello {this.props.name}</div>;
}
}
});
`
}, {
// Not a React component
code: `
class Hello {
render() {}
}
`
}, {
// ES6 class without a render method
code: 'class Hello extends React.Component {}'
}, {
// ES5 class without a render method
code: 'var Hello = createReactClass({});'
}, {
// ES5 class with an imported render method
code: `
var render = require('./render');
var Hello = createReactClass({
render
});
`
}, {
// Invalid render method (but accepted by Babel)
code: `
class Foo extends Component {
render
}
`,
parser: 'babel-eslint'
}],
invalid: [{
// Missing return in ES5 class
code: `
var Hello = createReactClass({
displayName: 'Hello',
render: function() {}
});
`,
errors: [{
message: 'Your render method should have return statement',
line: 4
}]
}, {
// Missing return in ES6 class
code: `
class Hello extends React.Component {
render() {}
}
`,
errors: [{
message: 'Your render method should have return statement'
}]
}, {
// Missing return (but one is present in a sub-function)
code: `
class Hello extends React.Component {
render() {
const names = this.props.names.map(function(name) {
return <div>{name}</div>
});
}
}
`,
errors: [{
message: 'Your render method should have return statement',
line: 3
}]
}, {
// Missing return ES6 class render property
code: `
class Hello extends React.Component {
render = () => {
<div>Hello {this.props.name}</div>
}
}
`,
parser: 'babel-eslint',
errors: [{
message: 'Your render method should have return statement',
type: 'ClassProperty'
}]
}]
});