/
jsx-no-useless-fragment.js
137 lines (122 loc) · 3.52 KB
/
jsx-no-useless-fragment.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
/**
* @fileoverview Disallow useless fragments
*/
'use strict';
const pragmaUtil = require('../util/pragma');
const jsxUtil = require('../util/jsx');
const docsUrl = require('../util/docsUrl');
function isJSXText(node) {
return !!node && (node.type === 'JSXText' || node.type === 'Literal');
}
module.exports = {
meta: {
type: 'suggestion',
fixable: 'code',
docs: {
description: 'Disallow unnecessary fragments',
category: 'Possible Errors',
recommended: false,
url: docsUrl('jsx-no-useless-fragment')
},
messages: {
NeedsMoreChidren: 'Fragments should contain more than one child - otherwise, there‘s no need for a Fragment at all.',
ChildOfHtmlElement: 'Passing a fragment to an HTML element is useless.'
}
},
create(context) {
const reactPragma = pragmaUtil.getFromContext(context);
const fragmentPragma = pragmaUtil.getFragmentFromContext(context);
/**
* Test whether a node is an padding spaces trimmed by react runtime.
* @param {ASTNode} node
* @returns {boolean}
*/
function isPaddingSpaces(node) {
return isJSXText(node)
&& /^\s*$/.test(node.raw)
&& node.raw.includes('\n');
}
/**
* Test whether a JSXElement has less than two children, excluding paddings spaces.
* @param {JSXElement|JSXFragment} node
*/
function hasLessThanTwoChildren(node) {
if (node.children.length < 2) {
return true;
}
return (
node.children.length
- Number(isPaddingSpaces(node.children[0]))
- Number(isPaddingSpaces(node.children[node.children.length - 1]))
) < 2;
}
/**
* @param {JSXElement|JSXFragment} node
* @returns {boolean}
*/
function isChildOfHtmlElement(node) {
return node.parent.type === 'JSXElement'
&& node.parent.openingElement.name.type === 'JSXIdentifier'
&& /^[a-z]+$/.test(node.parent.openingElement.name.name);
}
/**
* Avoid fixing case like:
* ```jsx
* <div>
* pine<>
* apple
* </>
* </div>
* ```
* @param {JSXElement|JSXFragment} node
* @returns {boolean}
*/
function isSafeToFix(node) {
if (!node.parent.children) {
return false;
}
const i = node.parent.children.indexOf(node);
const previousChild = node.parent.children[i - 1];
const nextChild = node.parent.children[i + 1];
return (
(!isJSXText(previousChild) || /\s$/.test(previousChild.value)) &&
(!isJSXText(nextChild) || /^\s/.test(nextChild.value))
);
}
function fix(node, fixer) {
return node.type === 'JSXFragment'
? [
fixer.remove(node.openingFragment),
fixer.remove(node.closingFragment)
]
: [
fixer.remove(node.openingElement),
fixer.remove(node.closingElement)
];
}
function checkNode(node) {
if (hasLessThanTwoChildren(node)) {
context.report({
node,
messageId: 'NeedsMoreChidren',
fix: isSafeToFix(node) ? (fixer => fix(node, fixer)) : null
});
}
if (isChildOfHtmlElement(node)) {
context.report({
node,
messageId: 'ChildOfHtmlElement',
fix: isSafeToFix(node) ? (fixer => fix(node, fixer)) : null
});
}
}
return {
JSXElement(node) {
if (jsxUtil.isFragment(node, reactPragma, fragmentPragma)) {
checkNode(node);
}
},
JSXFragment: checkNode
};
}
};