From 61f80d0f4b45679ec5de0afa332aeb3f48b67701 Mon Sep 17 00:00:00 2001
From: golopot <golopot@gmail.com>
Date: Sat, 16 Mar 2019 13:53:15 +0000
Subject: [PATCH] [Fix] `prop-types`: Fix false positive on computed member
 expression

Fixes #1259
---
 lib/util/usedPropTypes.js     |  6 +++++-
 tests/lib/rules/prop-types.js | 13 +++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 lib/util/usedPropTypes.js
 mode change 100644 => 100755 tests/lib/rules/prop-types.js

diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
old mode 100644
new mode 100755
index b24f5238b0..85cc51e076
--- a/lib/util/usedPropTypes.js
+++ b/lib/util/usedPropTypes.js
@@ -295,7 +295,11 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
         name = getPropertyName(node);
         if (name) {
           allNames = parentNames.concat(name);
-          if (node.parent.type === 'MemberExpression') {
+          if (
+            // Match props.foo.bar, don't match bar[props.foo]
+            node.parent.type === 'MemberExpression' &&
+            node.parent.object === node
+          ) {
             markPropTypesAsUsed(node.parent, allNames);
           }
           // Do not mark computed props as used.
diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
old mode 100644
new mode 100755
index 0babd91930..a16ad51293
--- a/tests/lib/rules/prop-types.js
+++ b/tests/lib/rules/prop-types.js
@@ -2303,6 +2303,19 @@ ruleTester.run('prop-types', rule, {
         const b = a::fn1();
       `,
       parser: 'babel-eslint'
+    },
+    {
+      // issue #1259
+      code: `
+        const Hello = props => {
+          const { notInProp } = dict[props.foo];
+          return <div />
+        }
+
+        Hello.propTypes = {
+          foo: PropTypes.number,
+        }
+      `
     }
   ],