From 6f14e16ead00f89a8bcb71919badafa5a110fccc Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Thu, 3 Oct 2019 14:29:52 -0400 Subject: [PATCH] [fix] `jsx-no-useless-fragment`: use `array-includes` over `.includes` for back compat --- lib/rules/jsx-no-useless-fragment.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/rules/jsx-no-useless-fragment.js b/lib/rules/jsx-no-useless-fragment.js index 778975068a..7ff30c2cfb 100644 --- a/lib/rules/jsx-no-useless-fragment.js +++ b/lib/rules/jsx-no-useless-fragment.js @@ -4,6 +4,8 @@ 'use strict'; +const arrayIncludes = require('array-includes'); + const pragmaUtil = require('../util/pragma'); const jsxUtil = require('../util/jsx'); const docsUrl = require('../util/docsUrl'); @@ -47,8 +49,8 @@ function trimLikeReact(text) { const leadingSpaces = /^\s*/.exec(text)[0]; const trailingSpaces = /\s*$/.exec(text)[0]; - const start = leadingSpaces.includes('\n') ? leadingSpaces.length : 0; - const end = trailingSpaces.includes('\n') ? text.length - trailingSpaces.length : text.length; + const start = arrayIncludes(leadingSpaces, '\n') ? leadingSpaces.length : 0; + const end = arrayIncludes(trailingSpaces, '\n') ? text.length - trailingSpaces.length : text.length; return text.slice(start, end); } @@ -92,7 +94,7 @@ module.exports = { function isPaddingSpaces(node) { return isJSXText(node) && isOnlyWhitespace(node.raw) && - node.raw.includes('\n'); + arrayIncludes(node.raw, '\n'); } /**