From 72a71b302c5f36ee3dd440da43737afc21cc311e Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Tue, 21 Aug 2018 13:27:24 -0700 Subject: [PATCH] =?UTF-8?q?[Fix]=20`jsx-no-target-blank`:=20don=E2=80=99t?= =?UTF-8?q?=20crash=20when=20there=E2=80=99s=20no=20value?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #1949. --- lib/rules/jsx-no-target-blank.js | 4 +++- tests/lib/rules/jsx-no-target-blank.js | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js index e4492874e0..daee012551 100644 --- a/lib/rules/jsx-no-target-blank.js +++ b/lib/rules/jsx-no-target-blank.js @@ -11,7 +11,9 @@ const docsUrl = require('../util/docsUrl'); // ------------------------------------------------------------------------------ function isTargetBlank(attr) { - return attr.name.name === 'target' && + return attr.name && + attr.name.name === 'target' && + attr.value && attr.value.type === 'Literal' && attr.value.value.toLowerCase() === '_blank'; } diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js index 4fbbb1e0d3..eb90cbd6e3 100644 --- a/tests/lib/rules/jsx-no-target-blank.js +++ b/tests/lib/rules/jsx-no-target-blank.js @@ -33,6 +33,7 @@ ruleTester.run('jsx-no-target-blank', rule, { valid: [ {code: ''}, {code: ''}, + {code: ''}, {code: ''}, {code: ''}, {code: 's'},