From 7425244d51ac36fb0da5bb3c308488b7fa5e2d70 Mon Sep 17 00:00:00 2001 From: golopot Date: Fri, 12 Jul 2019 19:29:59 +0800 Subject: [PATCH] refactor: avoid duplicate implementation for isJSXText --- lib/rules/jsx-no-useless-fragment.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/rules/jsx-no-useless-fragment.js b/lib/rules/jsx-no-useless-fragment.js index 8816e1aae0..d5fdf4916e 100644 --- a/lib/rules/jsx-no-useless-fragment.js +++ b/lib/rules/jsx-no-useless-fragment.js @@ -7,6 +7,9 @@ const pragmaUtil = require('../util/pragma'); const jsxUtil = require('../util/jsx'); const docsUrl = require('../util/docsUrl'); +function isJSXText(node) { + return !!node && (node.type === 'JSXText' || node.type === 'Literal'); +} module.exports = { meta: { @@ -34,7 +37,7 @@ module.exports = { * @returns {boolean} */ function isPaddingSpaces(node) { - return (node.type === 'JSXText' || node.type === 'Literal') + return isJSXText(node) && /^\s*$/.test(node.raw) && node.raw.includes('\n'); } @@ -65,10 +68,6 @@ module.exports = { && /^[a-z]+$/.test(node.parent.openingElement.name.name); } - function isJSXText(node) { - return !!node && (node.type === 'JSXText' || node.type === 'Literal'); - } - /** * Avoid fixing case like: * ```jsx