From bb2b8db251af2c5dd19eae1be2aa0da40a9d2eb9 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Fri, 17 Jul 2020 22:38:39 -0700 Subject: [PATCH] [Tests] `jsx-curly-brace-presence`, `jsx-no-comment-textnodes`: add passing tests Closes #2716. --- tests/lib/rules/jsx-curly-brace-presence.js | 15 +++++++++++++++ tests/lib/rules/jsx-no-comment-textnodes.js | 18 +++++++++++++----- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js index 58983a2ace..6d9772fb0c 100755 --- a/tests/lib/rules/jsx-curly-brace-presence.js +++ b/tests/lib/rules/jsx-curly-brace-presence.js @@ -400,6 +400,21 @@ ruleTester.run('jsx-curly-brace-presence', rule, { `, options: [{children: 'always'}] + }, + { + code: ` + const Component2 = () => { + return /*; + }; + ` + }, + { + code: ` + const Component2 = () => { + return /*; + }; + `, + options: [{props: 'never', children: 'never'}] } ], diff --git a/tests/lib/rules/jsx-no-comment-textnodes.js b/tests/lib/rules/jsx-no-comment-textnodes.js index 20fcd9171e..afb17dfdfd 100644 --- a/tests/lib/rules/jsx-no-comment-textnodes.js +++ b/tests/lib/rules/jsx-no-comment-textnodes.js @@ -378,16 +378,24 @@ ruleTester.run('jsx-no-comment-textnodes', rule, { `, parser: parsers.BABEL_ESLINT, errors: [{message: 'Comments inside children section of tag should be placed inside braces'}] + }, + { + code: ` + const Component2 = () => { + return /*; + }; + `, + errors: [{message: 'Comments inside children section of tag should be placed inside braces'}] } ].concat(parsers.TS([ { code: ` - class Comp1 extends Component { - render() { - return (
// invalid
); + class Comp1 extends Component { + render() { + return (
// invalid
); + } } - } - `, + `, parser: parsers['@TYPESCRIPT_ESLINT'], errors: [{message: 'Comments inside children section of tag should be placed inside braces'}] }, {