Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-handler-names: false positive when handler name begins with number #1686

Closed
jsphstls opened this issue Feb 9, 2018 · 3 comments
Closed

jsx-handler-names: false positive when handler name begins with number #1686

jsphstls opened this issue Feb 9, 2018 · 3 comments
Labels
bug help wanted

Comments

@jsphstls
Copy link
Contributor

jsphstls commented Feb 9, 2018

image

Fail:

onClick={this.handle123LogoClick}

Pass

onClick={this.handleLogo123Click}

123Logo is a fictional example.
@jsphstls jsphstls changed the title jsx-handler-names: false positive when handler name contains number jsx-handler-names: false positive when handler name begins with number Feb 10, 2018
@jsphstls
Copy link
Contributor Author

Pull request: #1689

@Moong0122
Copy link
Contributor

May I try to solve this bug?

@ljharb
Copy link
Member

ljharb commented Sep 20, 2020

@Moong0122 any issue with a "help wanted" label that doesn't have a linked PR is up for grabs. This one has #1689, though (which I'll take another look at) so i don't think any additional help is needed on this issue.

@ljharb ljharb closed this as completed in ac49944 Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @jsphstls @Moong0122