Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-typos: Fix failing createClass test #1721

Closed
ljharb opened this issue Mar 13, 2018 · 3 comments
Closed

no-typos: Fix failing createClass test #1721

ljharb opened this issue Mar 13, 2018 · 3 comments

Comments

@ljharb
Copy link
Member

ljharb commented Mar 13, 2018

Per #1671 (https://github.com/yannickcr/eslint-plugin-react/pull/1671/files#diff-a36b384ace30edac8eacb00c170eed54R1277) and #1389, there's a commented out no-typos test that should be uncommented and fixed.

@alexzherdev
Copy link
Contributor

I have a fix coming up for this, but that depends on #1827 to be merged.
I have one question though. I think the four commented out tests are really just two test cases which run with and without babel-eslint. Is that necessary in the case of createClass? I understood this comment to mean "one test for static properties with babel-eslint and one test for regular Component.propTypes = ... without babel-eslint". Do we need to also run non-babel-eslint tests with babel-eslint?

@ljharb
Copy link
Member Author

ljharb commented Jun 15, 2018

It’s not necessarily required, but it is ideal. Different parsers produce different AST node names, with different node schemas, so its useful to run them all through multiple parsers.

@alexzherdev
Copy link
Contributor

Ok, I have this ready. And it looks like #1827 is good to go, so I'll create a PR after that's done.

alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 15, 2018
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Sep 8, 2018
ljharb pushed a commit to alexzherdev/eslint-plugin-react that referenced this issue Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants