Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/jsx-no-target-blank false positive on multiple lines #1920

Closed
valan opened this issue Aug 9, 2018 · 4 comments
Closed

react/jsx-no-target-blank false positive on multiple lines #1920

valan opened this issue Aug 9, 2018 · 4 comments

Comments

@valan
Copy link

valan commented Aug 9, 2018

react/jsx-no-target-blank triggers a warning even when the ref param is correct if the ref and the target are on separate lines

example:

<a
    target="_blank"
    ref="noopener noreferrer"
    href="https://github.com/FormidableLabs/electron-webpack-dashboard"
>
    webpack-dashboard
</a>
@ljharb
Copy link
Member

ljharb commented Aug 10, 2018

That's ref - it should be rel.

@ljharb ljharb closed this as completed Aug 10, 2018
@damianobarbati
Copy link

damianobarbati commented Jan 18, 2020

@valan did you solve with that? @ljharb probably I'm dumb but I really can't figure out why I still have the warning.

Screenshot 2020-01-18 at 10 51 07

@ljharb
Copy link
Member

ljharb commented Jan 19, 2020

@damianobarbati if it works with a quote literal (instead of curly brackets), then I’d expect you need #2523 which is in v7.18.0. Please file a new issue if it’s still not working.

@damianobarbati
Copy link

Yes @ljharb it works with literal instead of brackets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants