prop-types rule reports for Array.prototype.reduce is missing

[ivalduan]

Similar to #1047 when a propType React.PropTypes.arrayOf(), you shouldn't be prompted to add reduce by eslint.
By extension any Array.prototype method that does not modify the data should be included.

[ivalduan]

Reproduced with v7.14.2

[ljharb]

Agreed, this is a bug

[golopot]

I cannot reproduce this. Can you share a snippet for reproduction?

import React from 'react';
import PropTypes from 'prop-types';

function Foo({ a }) {
  return <p>{a.reduce(() => 5)}</p>;
}

Foo.propTypes = {
  a: PropTypes.arrayOf(PropTypes.string).isRequired,
};

[ivalduan]

Thought it was simple but it seems like the problem goes in another direction.

I was able to reproduce with the following snippet, it seems to be related with identifier collision when parsing the code, if the destructured variable is named differently than the root prop eslint recognizes well the array and the reduce.

import React from 'react';
import PropTypes from 'prop-types';

function Foo({
  elements: {
    items: elements,
  },
}) {
  return <p>{elements.reduce(() => 5)}</p>;
}

Foo.propTypes = {
  elements: PropTypes.shape({
    items: PropTypes.arrayOf(PropTypes.string).isRequired,
  }).isRequired,
};