react/jsx-sort-props + {ignoreCase: false} now ignores case when sorting props

[hawkrives]

I've found an unexpected(?) change that stems from #2391.

<Hello name="John" Number="2" />

With {ignoreCase: false}, which according to the docs should take case into account when sorting the props, the above example now expects name to be sorted before Number.

I know why it sorts the way it does: #2391 switched to using String#localeCompare, which does…

> 'name'.localeCompare('Number')
-1

Looking at the lib/rules/jsx-sort-props.js code, I'm not sure what changes would be required to accommodate both this issue and #2381, unfortunately.

So, the crux of this issue is: is this an unexpected change, or should I alter my expectations and update the documentation to reflect this behavior?

[ljharb]

This definitely seems like an unexpected change.

[ljharb]

Specifically, we should probably only use localeCompare when ignoreCase is true?

[jcarty]

@ljharb any news on this one?

[ljharb]

No, "help wanted" means it's awaiting a PR.

[tanmoyopenroot]

We can't depend on localeCompare as it is not reliable.
Example:

Therefore, we need to replace localeCompare from line and line.

[tanmoyopenroot]

Hi @hawkrives ,
I have added a PR, Can you check the test cases?

[ljharb]

@tanmoyopenroot we must depend on localeCompare whenever possible since english isn't the only language in the world.

[tanmoyopenroot]

@ljharb But each character in a string in any language will be compared in Unicode order for comparison operator.
In Unicode everything is ordered alphabetically.

[ljharb]

If that were true, there'd be no point in the localeCompare method existing.

[tanmoyopenroot]

I will try to fix it using localeCompare .