Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-comments-in-text-node seems to be broken with @typescript-eslint/parser #2599

Closed
Axnyff opened this issue Mar 20, 2020 · 2 comments · Fixed by #2601
Closed

no-comments-in-text-node seems to be broken with @typescript-eslint/parser #2599

Axnyff opened this issue Mar 20, 2020 · 2 comments · Fixed by #2601

Comments

@Axnyff
Copy link
Contributor

Axnyff commented Mar 20, 2020

Hello,

I've recently had had a bug with a comment text node and realizer the rule does not seem to work while using @typescript-eslint/parser.

I've created a draft pr which seems to fix the problem while not breaking the existing behavior:
https://github.com/Axnyff/eslint-plugin-react/commit/d47233c486cd0423a90a8d81884db22ad391a800

Disclaimer: I had this warning while testing

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~3.1.1

YOUR TYPESCRIPT VERSION: 3.8.3

but unless I'm mistaken, it doesn't matter in my case.

Thanks for your help.

@ljharb
Copy link
Member

ljharb commented Mar 23, 2020

A PR with a failing test would be most helpful.

@Axnyff
Copy link
Contributor Author

Axnyff commented Mar 23, 2020

Hi, I've created this PR: #2601.

It seems that this snippet would fix the bug 13673b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants