Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rule from TSLint: react-iframe-missing-sandbox #2754

Closed
tosmolka opened this issue Aug 13, 2020 · 4 comments · Fixed by #2753
Closed

Migrate rule from TSLint: react-iframe-missing-sandbox #2754

tosmolka opened this issue Aug 13, 2020 · 4 comments · Fixed by #2753

Comments

@tosmolka
Copy link
Contributor

tosmolka commented Aug 13, 2020

We would like to port react-iframe-missing-sandbox from tslint-microsoft-contrib into ESLint and this plugin seems like a good place to put it.

See initial PR:
#2753

Any feedback will be appreciated!

@tosmolka tosmolka changed the title Proposed rule: iframe-missing-sandbox Migrate rule from TSLint: react-iframe-missing-sandbox Aug 13, 2020
@ljharb
Copy link
Member

ljharb commented Aug 13, 2020

What is the purpose of this rule?

A PR is premature before it's clear this is a rule we want.

@tosmolka
Copy link
Contributor Author

We use this rule internally to remind engineers to follow security best practices and use "sandbox" attribute on iframes to enable only the functionality that is required. PR is here to show what the rule actually does.

I'll certainly leave it for your consideration. More reading on the iframe sandbox, if needed:

@tosmolka
Copy link
Contributor Author

@ljharb , any news regarding the proposal? Thank you.

@ljharb
Copy link
Member

ljharb commented Sep 24, 2020

@tosmolka i think this is fine - let's go with iframe-missing-sandbox, and let's make sure that it works for both jsx and React.createElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants