react-redux/no-unused-prop-types: False positive on props used within react-dnd dropSpec

[bhollis]

Since upgrading to 7.25.0 I get false positives on prop types defined in TypeScript that are used within react-dnd dropSpec functions but not within the component itself. e.g. https://github.com/DestinyItemManager/DIM/blob/master/src/app/destiny1/loadout-builder/LoadoutBuilderDropTarget.tsx

[ljharb]

This may be related to #3054.

[traverse]

Running into a similar issue reproducible with the following code

interface Props {
  propA: string
  propB: number // marked as unused
}

function MyComponent(props: Props) {
  someLogicThatUsesProps(props)
  
  return <div>{props.propA}</div>
}

function someLogicThatUsesProps(props: Props) {
  if (props.propA !== '') return props.propA
  if (props.propB !== 0) return props.propB

  return 'some default'
}

In my case there's a bit more logic involved and several more props but I think it gets the point across.

[ljharb]

@traverse in that case, that's just the limits of static analysis - you should be destructuring props and passing things explicitly - props objects should never be directly passed anywhere else, for a number of reasons.

[bhollis]

This is not fixed in 7.25.1.

[bhollis]

Sorry, I didn't catch that this is in eslint-plugin-react-redux, not eslint-plugin-react.