New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react/no-invalid-html-attribute
seems to report false positives
#3172
Comments
I'm pretty sure a rel of "home" was never official; that link is to a draft. If you choose not to name the file |
Alright fair enough, thanks for checking 👍🏻 |
OK I will just remove that line entirely. 👍🏻 For future people stranding here it might also be worth mentioning:
|
If the html specification allows it, then we should also, to be clear. |
Yeah I just wonder how much "quirks mode" that is 😅 |
Very, but if it’s valid, then it can’t hurt to support it. |
Then I can offer you #3174 😄 |
Hey there, I've got an automatic lint bump in my repo that introduces
react/no-invalid-html-attribute
as a new rule and it fails with two/three errors:https://github.com/Primajin/eyesbound/runs/4760311505?check_suite_focus=true
By adding rel="home" to a hyperlink, a page indicates that the destination of that hyperlink is the homepage of the site [...]
https://microformats.org/wiki/rel-home
This is a draft from 2005... Not sure if it was ever official?
If I read https://mathiasbynens.be/notes/rel-shortcut-icon correctly this is not according to specification but older IE need it when the file is not exactly called
favicon.ico
, is that correct?So are these arguably false positives, or instead everyone is just using it wrong and it was never a specification - thus I still wonder if everyone uses it kind of makes it a default 🤔 😅
Thanks for looking into it folks.
The text was updated successfully, but these errors were encountered: