From 7ee943140079139ddb07775163233c7c8b57ceb3 Mon Sep 17 00:00:00 2001 From: Alex Zherdev Date: Tue, 30 Oct 2018 21:12:46 -0700 Subject: [PATCH 1/2] `jsx-fragments`: improve message text --- lib/rules/jsx-fragments.js | 3 ++- tests/lib/rules/jsx-fragments.js | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/rules/jsx-fragments.js b/lib/rules/jsx-fragments.js index da9d97322e..6a68697f27 100644 --- a/lib/rules/jsx-fragments.js +++ b/lib/rules/jsx-fragments.js @@ -47,7 +47,8 @@ module.exports = { if (!versionUtil.testReactVersion(context, '16.2.0')) { context.report({ node, - message: 'Fragments are only supported starting from React v16.2' + message: 'Fragments are only supported starting from React v16.2. ' + + 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.' }); return true; } diff --git a/tests/lib/rules/jsx-fragments.js b/tests/lib/rules/jsx-fragments.js index c230085040..640f029c7a 100644 --- a/tests/lib/rules/jsx-fragments.js +++ b/tests/lib/rules/jsx-fragments.js @@ -88,13 +88,15 @@ ruleTester.run('jsx-fragments', rule, { parser: 'babel-eslint', settings: settingsOld, errors: [{ - message: 'Fragments are only supported starting from React v16.2' + message: 'Fragments are only supported starting from React v16.2. ' + + 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.' }] }, { code: '', settings: settingsOld, errors: [{ - message: 'Fragments are only supported starting from React v16.2' + message: 'Fragments are only supported starting from React v16.2. ' + + 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.' }] }, { code: '<>', From 7d2eb6a15b68bef1bf2bf7c39a180aedfc8d1345 Mon Sep 17 00:00:00 2001 From: Alex Zherdev Date: Tue, 30 Oct 2018 22:55:08 -0700 Subject: [PATCH 2/2] [Dev Deps] update `typescript-eslint-parser` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5a0c783aef..4ecf3f8e7d 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "istanbul": "^0.4.5", "mocha": "^5.2.0", "typescript": "^3.1.3", - "typescript-eslint-parser": "^20.0.0" + "typescript-eslint-parser": "^20.1.1" }, "peerDependencies": { "eslint": "^3.0.0 || ^4.0.0 || ^5.0.0"