From 0f8d79020e67bbc4ba5830c743bcb20238024797 Mon Sep 17 00:00:00 2001 From: Rafael Garcia Date: Thu, 12 Dec 2019 19:28:29 -0300 Subject: [PATCH] [Fix] `jsx-curly-brace-presence`: Fix error related to tags line break Fixes #1727. --- lib/rules/jsx-curly-brace-presence.js | 8 ++++++-- tests/lib/rules/jsx-curly-brace-presence.js | 15 +++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js index ad273c2d0a..95a8806bf7 100755 --- a/lib/rules/jsx-curly-brace-presence.js +++ b/lib/rules/jsx-curly-brace-presence.js @@ -298,7 +298,11 @@ module.exports = { return areRuleConditionsSatisfied(parent, config, OPTION_NEVER); } - function shouldCheckForMissingCurly(parent, config) { + function shouldCheckForMissingCurly(node, config) { + if (node.raw.trim() === '') { + return false; + } + const parent = node.parent; if ( parent.children && parent.children.length === 1 && @@ -322,7 +326,7 @@ module.exports = { }, 'Literal, JSXText': (node) => { - if (shouldCheckForMissingCurly(node.parent, userConfig)) { + if (shouldCheckForMissingCurly(node, userConfig)) { reportMissingCurly(node); } } diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js index 3d10885cdb..ec295c9337 100755 --- a/tests/lib/rules/jsx-curly-brace-presence.js +++ b/tests/lib/rules/jsx-curly-brace-presence.js @@ -376,6 +376,21 @@ ruleTester.run('jsx-curly-brace-presence', rule, { Bar}> ` + }, + { + code: ` + +
+

+ + {"foo"} + +

+
+
+ `, + parser: parsers.BABEL_ESLINT, + options: [{children: 'always'}] } ],