Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS Mojave dark mode #35

Closed
jsynowiec opened this issue Sep 25, 2018 · 3 comments
Closed

Support macOS Mojave dark mode #35

jsynowiec opened this issue Sep 25, 2018 · 3 comments

Comments

@jsynowiec
Copy link
Owner

jsynowiec commented Sep 25, 2018

Apple released design resources for macOS: Introducing Apple Design Resources for macOS
There are also videos from WWDC, e.g. "Introducing Dark Mode" and guidelines, AppKit Article - Supporting Dark Mode in Your Interface.

Blocked by: electron/electron#14755

@jsynowiec jsynowiec changed the title Support macOS Mojave dark mode support Support macOS Mojave dark mode Sep 26, 2018
@DCzajkowski
Copy link
Contributor

Isn't this enough?

const { systemPreferences: { isDarkMode } } = require('electron')
if (isDarkMode()) {
  // set dark theme
} else {
  // set light theme
}

@jsynowiec
Copy link
Owner Author

As a temporary solution, maybe.

But I to do it properly, application should support NSApplication.appearance. And this is what electron/electron#14755 adds.

Nevertheless, this has a low priority for me currently. There is no support for proper theming in the app right now and I'm focused on other parts.

@jsynowiec
Copy link
Owner Author

jsynowiec commented Mar 26, 2019

This is how it'll look in the next version. Light and dark appearance. It changes in response to the system settings so if one uses F.lux or some other app to automatically change between appearances on sunset, then Airqmon adapts in background. Vibrancy is also supported. In the end I removed vibrancy support. Text was hard to read on some wallpapers.

macOS Light appearancemacOS Dark appearance

This might interest you @thymikee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants