Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: [breaking change] sveltekit 1.0.0-next.539 #190

Open
Nushio opened this issue Nov 15, 2022 · 0 comments
Open

bug: [breaking change] sveltekit 1.0.0-next.539 #190

Nushio opened this issue Nov 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Nushio
Copy link
Collaborator

Nushio commented Nov 15, 2022

Describe the Bug

Omit prerendered routes from server manifest

With this change, the prerendered routes are no longer known/available in the svelte-adapter-firebase ssr function.
When the browser makes a request to firebase hosting, instead it gets directed to the ssr function, which no longer knows "what" to do, and returns an error instead such as:

Error: Not found: /

Steps to Reproduce

  1. Create a new sveltekit app, with sveltekit 1.0.0-next.539 or above
  2. Create a prerendered route, such as /
  3. Visit said pre-rendered route

Other non-prerendered routes are 'safe'

Expected Behaviour

The app works as intended and serves the route.

svelte-adapter-firebase version

0.14.4

sveltejs/kit version

1.0.0-next.539

@Nushio Nushio added the bug Something isn't working label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant