Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Documentation should show esbuildOptions, not esbuildBuildOptions #208

Open
tbuckley opened this issue Mar 4, 2023 · 0 comments
Open

bug: Documentation should show esbuildOptions, not esbuildBuildOptions #208

tbuckley opened this issue Mar 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tbuckley
Copy link

tbuckley commented Mar 4, 2023

Describe the Bug

The documentation in README.md guides users to use esbuildBuildOptions to configure esbuild. However the code actually uses esbuildOptions : https://github.com/jthegedus/svelte-adapter-firebase/blob/main/src/index.js#L20

Steps to Reproduce

  1. Add esbuildBuildOptions configuration to svelte.config.js, eg adding target: "esm"

Expected Behaviour

The configuration options should apply

svelte-adapter-firebase version

0.15.0

sveltejs/kit version

1.7.2
@tbuckley tbuckley added the bug Something isn't working label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbuckley