Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TypeScript Support & Example #8

Open
jthegedus opened this issue Feb 8, 2021 · 1 comment
Open

docs: TypeScript Support & Example #8

jthegedus opened this issue Feb 8, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jthegedus
Copy link
Owner

jthegedus commented Feb 8, 2021

Describe the bug

TypeScript may cause issues because our SvelteKit app is already built when the build output lands in functions/lib/<site name>/.

How should this be recommended to users? If they include the compiled relative import in the uncompiled TS then the app may attempt to be recompiled by the TS compilation of the functions, which we do not want 🤔

EG:

// functions/src/index.ts
svelteKit = require("../lib/<site name>/handler").sveltekitServer;` 

This relative dir will be correct in the compiled code in functions/lib/index.js, but if the SvelteKit code is also passed through the TS compiler then we may have issues.

@jthegedus jthegedus added the bug Something isn't working label Feb 8, 2021
@jthegedus jthegedus self-assigned this Feb 8, 2021
@jthegedus jthegedus changed the title TypeScript Example TypeScript Support & Example Feb 8, 2021
@jthegedus jthegedus changed the title TypeScript Support & Example docs: TypeScript Support & Example Mar 22, 2021
@jthegedus jthegedus added documentation Improvements or additions to documentation and removed bug Something isn't working labels Mar 22, 2021
@joefhall
Copy link

+1 for this -- would be great to have easy integration with Typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants