Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: BinaryBuilder returns 0 (success) on failure #1372

Open
1 task done
dubajj opened this issue Apr 3, 2024 · 1 comment
Open
1 task done

[Bug]: BinaryBuilder returns 0 (success) on failure #1372

dubajj opened this issue Apr 3, 2024 · 1 comment

Comments

@dubajj
Copy link

dubajj commented Apr 3, 2024

Detailed steps on how to reproduce the bug

  1. use a non-existent source directory with BinaryBuilder
  2. Note the output Source directory doesn't exist: ...
  3. Note the return value from the executable is 0 aka "success"

This is true for all failure cases in BinaryBuilder.

What is the expected behaviour?

An executable failing should return a non-zero value to the OS

Operating systems

Other

What versions of the operating systems?

Windows
MacOS
Linux

Architectures

Other, 64-bit

Stacktrace

No response

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

  • I agree to follow the Code of Conduct
@dubajj
Copy link
Author

dubajj commented Apr 3, 2024

As a bonus, it would be nice to use cerr instead of cout for error printing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dubajj