Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta/sql: use binary as column type for xattr #4873

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

meta/sql: use binary as column type for xattr #4873

wants to merge 2 commits into from
+17 −8

Conversation

davies
Copy link
Contributor

@davies davies commented May 20, 2024

close #4803

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (fc2d91d) to head (878d184).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4873      +/-   ##
==========================================
+ Coverage   44.86%   54.52%   +9.65%     
==========================================
  Files         158      160       +2     
  Lines       42872    43351     +479     
==========================================
+ Hits        19233    23635    +4402     
+ Misses      21228    17036    -4192     
- Partials     2411     2680     +269

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SandyXSD
Copy link
Contributor

We have to update the table schema manually if we want this change, see:
https://juicefs.com/docs/community/release_notes/#juicefs-v10

@davies davies marked this pull request as draft May 21, 2024 02:41
@SandyXSD
Copy link
Contributor 

# sqlite as the meta engine
# old version
root@dev:/mnt/jfs# xattr -w testkey testval f
root@dev:/mnt/jfs# xattr -l f
testkey: testval
# with this PR
root@dev:/mnt/jfs# xattr -l f
No such xattr: testkey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setxattr failed with special name.
2 participants
@davies @SandyXSD