Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipfile break on node >= 6.4 #25

Open
gimox opened this issue Oct 3, 2016 · 1 comment
Open

zipfile break on node >= 6.4 #25

gimox opened this issue Oct 3, 2016 · 1 comment

Comments

@gimox
Copy link

gimox commented Oct 3, 2016

On nodejs >= 6.4 zipfile lib break install.

For a working version i removed zipfile as dependance!!

@nbrustein
Copy link

I'm seeing issues with zipfile on node v6.11.5. Some files get unzipped successfully. Others fail. This is a link to one file that is not working: https://www.buecher.de/shop/schauspieler/der-junge-muss-an-die-frische-luft/kerkeling-hape/products_products/detail/prod_id/44880761/ (It is not free. I can send you a copy of it privately if you need it)

I was able to hack around the problem by doing the following before requiring epub:


    var zipfile = require('zipfile');
    Object.defineProperty(zipfile, 'ZipFile', {
        get: function() {
            throw new Error('Disable ZipFile.');
        }
    });

That causes zipfile to blow up when epub tries to load it, forcing epub to fall back to the js-only implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants