Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include specific external elements #12

Open
JacobDB opened this issue Aug 17, 2016 · 4 comments
Open

Include specific external elements #12

JacobDB opened this issue Aug 17, 2016 · 4 comments

Comments

@JacobDB
Copy link

JacobDB commented Aug 17, 2016

This works great, except that there's no way for my users to toggle the "close dialog" button, as it's a global overlay not within the same menu. I'll see if I can change my code to make it work as I need it to, but it'd be awesome to say "trap within this div, except also include this one"

@julienw
Copy link
Owner

julienw commented Aug 29, 2016

Maybe we could add such additions in the "result" array in

How would you see the API ? Something like:

        $(".trap").trap({ except: jQueryObject });
        $(".trap").trap({ except: [ object1, object2, ... ] }); // "object1" is either a jQ object or plain DOM

TBH I don't work with jQuery for several years now :)

@JacobDB
Copy link
Author

JacobDB commented Aug 30, 2016

That sounds like it'd work well to me.

Unrelated, but I'm trying to move away from jQuery as well, but finding it difficult to transition to native JS. Do you have any tips on how to get started? I feel like I'm somewhat profeciant in jQuery but native JS seems completely different 😰

@julienw
Copy link
Owner

julienw commented Aug 30, 2016

I looked quickly and I found https://gomakethings.com/ditching-jquery/ which seems quite comprehensive :)

@JacobDB
Copy link
Author

JacobDB commented Aug 30, 2016

Thanks much, will check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants