Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DisplayNameGenerator to support CamelCase, underscores, and numbers #793

Open
Michael1993 opened this issue Nov 29, 2023 · 10 comments
Assignees

Comments

@Michael1993
Copy link
Member

See the JUnit 5 issues: #3569 and #1595.

If JUnit 5 decides not to host/support this, I think we should - let's wait for their team decision. 😄

@Bukama
Copy link
Member

Bukama commented Dec 9, 2023

Added label "blocked" for now, until JUnit team decided

@Michael1993
Copy link
Member Author

Michael1993 commented Mar 30, 2024

We are Pioneers! We bravely go where no man has gone before!

I say let's integrate this into Pioneer and if JUnit decides to officially support this we can still remove/deprecate it.
(Me, impatient? Never!)

@Bukama
Copy link
Member

Bukama commented Mar 31, 2024

We are Pioneers! We bravely go where no man has gone before!

I say let's integrate this into Pioneer and if JUnit decides to officially support this we can still remove/deprecate it. (Me, impatient? Never!)

Convinced :) Do you start the countdown? 🚀

@Bukama
Copy link
Member

Bukama commented Apr 23, 2024

Added label "blocked" for now, until JUnit team decided

Well they have decicded on #1595 already in 2020 to not implement it, cause of edge cases. I thin that opens the door for pioneering it even more

@FanJups
Copy link

FanJups commented Apr 23, 2024

Added label "blocked" for now, until JUnit team decided

Well they have decicded on #1595 already in 2020 to not implement it, cause of edge cases. I thin that opens the door for pioneering it even more

Great, lets go 😊

@FanJups
Copy link

FanJups commented Apr 27, 2024

So, can I PR ?

@Michael1993
Copy link
Member Author

So, can I PR ?

Yes, feel free to go ahead with a PR. If you don't have the time for it, we will eventually get around to it.

@FanJups
Copy link

FanJups commented May 10, 2024

@Bukama , please assign me this issue.

@Bukama
Copy link
Member

Bukama commented May 11, 2024

@Bukama , please assign me this issue.

Hey @FanJups On our yesterdays team meeting we talked about this issue and as you have not responded to @Michael1993 comment in any kind of form (comment, question or PR) we assumed that you abandoned the topic and @Michael1993 volunteered to give it a shot.

I will assign the issue to you now, but assuming you will present any progress on it (e.g. a draft PR) in the near future.

@FanJups
Copy link

FanJups commented May 11, 2024

@Bukama , please assign me this issue.

Hey @FanJups On our yesterdays team meeting we talked about this issue and as you have not responded to @Michael1993 comment in any kind of form (comment, question or PR) we assumed that you abandoned the topic and @Michael1993 volunteered to give it a shot.

I will assign the issue to you now, but assuming you will present any progress on it (e.g. a draft PR) in the near future.

Thanks @Bukama , it will be ready for review no later than May 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants