Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom memory pool support #597

Open
roypaulin opened this issue Jun 16, 2022 · 2 comments
Open

Custom memory pool support #597

roypaulin opened this issue Jun 16, 2022 · 2 comments

Comments

@roypaulin
Copy link

Hello, hope this finds you well. We're using this library and are happy with its performance in general

We have our own memory pool that we would like to use in the library as managing the memory ourselves is something really important for us. So is implementing some classes so they can accept a custom pool something you are considering or open to do anytime soon?

What are your general thoughts about that?

@gjasny
Copy link
Collaborator

gjasny commented Jun 20, 2022

Hi,

what do you mean with "own memory pool"? Something like an STL allocator?

Do you care only about the instrumented code? That one that increments the Counters, Gauges, and Histograms? Usually, once set-up with all required labels it should not allocate at all.

The collecting side is run from a different thread and there runtime usually is not too critical.

Thanks,
Gregor

@roypaulin
Copy link
Author

roypaulin commented Jun 21, 2022

Yes we mean an allocator that you can use as an STL allocators. But we would like to use it if possible for any new calls. If that isn't feasible to do this for all allocations, targeting the memory that is long lived is more important as our server runs for a very long time. Short duration allocations are fine to skip.

Thanks,
Roy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants