Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary Quantiles/Errors #647

Open
rmccorm4 opened this issue Apr 9, 2023 · 1 comment
Open

Summary Quantiles/Errors #647

rmccorm4 opened this issue Apr 9, 2023 · 1 comment

Comments

@rmccorm4
Copy link

rmccorm4 commented Apr 9, 2023

Hi, I had a few questions revolving around value settings for quantiles and their corresponding errors.

I noticed there are no errors or exceptions for setting quantile<0 or quantile>1, and similarly for error<0 or error>1. However, when these values get pushed through upon metric creation, I'm not sure what they're actually interpreting.

I see in the Java client, some of the behavior around zero values is explicitly documented:

  • You can set an allowed error of 0, but then the Summary will keep all observations in memory.
  • You can track the minimum value with .quantile(0.0, 0.0). This special case will not use additional memory even though the allowed error is 0.
  • You can track the maximum value with .quantile(1.0, 0.0). This special case will not use additional memory even though the allowed error is 0.

And values outside of the 0/1 bounds are rejected.

Can you help explain the expected behavior for similar values in the prometheus-cpp implementation?

CC @Romain-Geissler-1A @jupp0r

@dc6c
Copy link

dc6c commented Apr 25, 2023

Tracking maximum/minimum value is exactly the use case that led me to this issue -- it would be great to see the Quantile(1, 0) case optimized like that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants