Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to BCR ? #704

Closed
mmorel-35 opened this issue Mar 17, 2024 · 3 comments
Closed

Publish to BCR ? #704

mmorel-35 opened this issue Mar 17, 2024 · 3 comments

Comments

@mmorel-35
Copy link
Contributor

Prometheus-cpp doesn't seems to be available on https://github.com/bazelbuild/bazel-central-registry/tree/main/modules

Have you considered publishing Prometheus-cpp in the registry ?

That could be really helpful to use it without needing to use git_override.

Thank you !

@gjasny
Copy link
Collaborator

gjasny commented Mar 17, 2024

Hi,

yes, I considered it but there are two dependencies missing in BCR: civetweb and curl.

Right now I don’t have the bandwidth to add them myselves.

Thanks,
Gregor

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 17, 2024

I don't think you need to have all the dependencies of a project in the BCR to add it.
I believe Prometheus-cpp could be added with it's actual MODULE.bazel

I create a PR do do this : bazelbuild/bazel-central-registry#1637

@gjasny
Copy link
Collaborator

gjasny commented Mar 17, 2024

Thanks for your work! Once the PR in BCR is merged, could you please add a small section to the readme?

@gjasny gjasny closed this as completed in b253ae9 May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants