Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old TODO's and clean up #160

Open
5 of 11 tasks
MCWertGaming opened this issue Dec 9, 2021 · 2 comments
Open
5 of 11 tasks

old TODO's and clean up #160

MCWertGaming opened this issue Dec 9, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MCWertGaming
Copy link
Collaborator

MCWertGaming commented Dec 9, 2021

We need to implement all TODO's and clean up the code a bit:

  • move constants in conversion.hpp into a enum
  • change linux sscanf to something better (clang-tidy issue) (TODO)
  • Silently disable raw mode if the terminal is not interactive (TODO)
  • skip adding a number to ansi codes on 0 (0 is the deafult value if no value is specified)
  • throw runtime errors on wrong values for ANSI functions
  • optimize datatypes (use for 0 - 255 ranges uint8_t)
  • make the code available for unsupported sequences in input function
  • merge window and window24 together
  • add screen parameter to window class (TODO)
  • make a function out of the ansi code from the new prompt
  • remove function names from headers
@MCWertGaming MCWertGaming added the enhancement New feature or request label Dec 9, 2021
@MCWertGaming MCWertGaming added this to the V1.0.0 milestone Dec 9, 2021
@MCWertGaming MCWertGaming added this to To do in CPP-Terminal via automation Dec 9, 2021
@MCWertGaming MCWertGaming self-assigned this Dec 9, 2021
@MCWertGaming MCWertGaming moved this from To do to V1.0.0 in CPP-Terminal Dec 9, 2021
@MCWertGaming MCWertGaming moved this from V1.0.0 to next up in CPP-Terminal Sep 16, 2022
@flagarde
Copy link
Collaborator

flagarde commented Mar 8, 2023

@MCWertGaming

We need to implement all TODO's and clean up the code a bit:

  • move constants in conversion.hpp into a enum
  • change linux sscanf to something better (clang-tidy issue) (TODO)
  • Silently disable raw mode if the terminal is not interactive (TODO)
  • skip adding a number to ansi codes on 0 (0 is the deafult value if no value is specified)
  • throw runtime errors on wrong values for ANSI functions
  • optimize datatypes (use for 0 - 255 ranges uint8_t)
  • make the code available for unsupported sequences in input function
  • merge window and window24 together
  • add screen parameter to window class (TODO)
  • make a function out of the ansi code from the new prompt
  • remove function names from headers

@MCWertGaming
Copy link
Collaborator Author

Updated the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: next up
Development

No branches or pull requests

2 participants