Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include for cmake #197

Open
MCWertGaming opened this issue Sep 26, 2022 · 2 comments
Open

Fix include for cmake #197

MCWertGaming opened this issue Sep 26, 2022 · 2 comments
Assignees
@MCWertGaming
Labels
enhancement New feature or request
Projects
CPP-Terminal
Milestone
V2.0.0

Comments

@MCWertGaming
Copy link
Collaborator

#196 changed the include from using <> to "". We should investigate if there is a case with cmake that actually requires "".
@MCWertGaming MCWertGaming added the enhancement New feature or request label Sep 26, 2022
@MCWertGaming MCWertGaming added this to To do in CPP-Terminal via automation Sep 26, 2022
@MCWertGaming MCWertGaming added this to the V2.0.0 milestone Sep 26, 2022
@MCWertGaming MCWertGaming self-assigned this Sep 26, 2022
@MCWertGaming MCWertGaming mentioned this issue Sep 26, 2022
Merged
@flagarde
Copy link
Collaborator

Cmake doesn't need it. some compiler make a distiction about <> and "" but it's mainly more a convention than very usefull. From my understanding <> is for system include search first while "" is for the project inlcude folder first

@flagarde
Copy link
Collaborator

@MCWertGaming This should be closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MCWertGaming MCWertGaming

Labels
enhancement New feature or request
Projects
CPP-Terminal
Status: To do
CPP-Terminal
To do
Milestone
V2.0.0
Development

No branches or pull requests
2 participants
@flagarde @MCWertGaming