Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example 'kilo' does not support special characters #246

Open
Ryder17z opened this issue May 8, 2023 · 7 comments
Open

example 'kilo' does not support special characters #246

Ryder17z opened this issue May 8, 2023 · 7 comments

Comments

@Ryder17z
Copy link

Ryder17z commented May 8, 2023

"Debug Assertion Failed"
points to file "minkernel/crts/ucrt/appcrt/convert/istype.cpp" line 36
"Expression: c > = -1 && c < = 255"

Would be nice to have utf-8 support, or at least utilize the older windows component for supporting non-english characters like 'å'

@flagarde
Copy link
Collaborator

flagarde commented May 8, 2023

@Ryder17z I agree this is a problem I'm aware of. I worked a bit on this but still not PR for now. I imagine example are here to show what the library can do and to trigger such problem and propose some changes to the library to fix them.

@certik
Copy link
Collaborator

certik commented May 8, 2023

I see. The other examples support utf8, but not kilo. We'll have to fix it. Thanks @flagarde for working on it.

@flagarde
Copy link
Collaborator

flagarde commented May 9, 2023

@Ryder17z Could you give me more informations :

  1. which line create the crash ?
  2. Which text are you writing ?
  3. You open a file or write it ?

I guess you are using window$ ?

@Ryder17z
Copy link
Author

Ryder17z commented May 9, 2023 via email

@flagarde
Copy link
Collaborator

flagarde commented May 9, 2023

@Ryder17z By the way, are you using the tag 1.0.0 or the upstream version ?

@Ryder17z
Copy link
Author

Ryder17z commented May 9, 2023

just whatever is on the master branch

@flagarde
Copy link
Collaborator

flagarde commented May 9, 2023

Stange this is encoded by 2 bits so it should be exclude from key value for now.. I will investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants