Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the implementation of comm_manager getters #400

Open
JohanMabille opened this issue May 7, 2024 · 1 comment
Open

Hide the implementation of comm_manager getters #400

JohanMabille opened this issue May 7, 2024 · 1 comment

Comments

@JohanMabille
Copy link
Member

The current implementation of xinterpreter::comm_manager is inlined in the header. It should (if possible) be moved to the source file.
@JohanMabille
Copy link
Member Author

Actually, most of the implementation of the comms is also inlined, we should check that it doe snot break anything before hiding iit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohanMabille