Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

StringSearch should be removed from completion model #220

Open
afshin opened this issue May 26, 2016 · 0 comments
Open

StringSearch should be removed from completion model #220

afshin opened this issue May 26, 2016 · 0 comments

Comments

@afshin
Copy link
Member

afshin commented May 26, 2016

The StringSearch module in completion/model.ts is a direct copy of the search algorithm in phosphor-core. Once phosphor-core is integrated with jupyter-js-notebook and the old phosphor libs are upgraded, this namespace should be removed in favor of the library version.

cf. #170

cc: @blink1073 @sccolbert @jasongrout

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant