.github/workflows/enforce-label.yml

@@ -1,15 +1,13 @@
 name: Enforce PR label
 
-concurrency:
-  group: label-${{ github.ref }}
-  cancel-in-progress: true
-
 on:
   pull_request:
     types: [labeled, unlabeled, opened, edited, synchronize]
 jobs:
   enforce-label:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
     steps:
       - name: enforce-triage-label
         uses: jupyterlab/maintainer-tools/.github/actions/enforce-label@v1

.pre-commit-config.yaml

@@ -16,7 +16,7 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/asottile/reorder_python_imports
-    rev: v3.0.1
+    rev: v3.1.0
     hooks:
       - id: reorder-python-imports
 
@@ -51,7 +51,7 @@ repos:
         stages: [manual]
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.942
+    rev: v0.950
     hooks:
       - id: mypy
         exclude: jupyter_client/tests

jupyter_client/client.py

@@ -337,11 +337,11 @@ def stop_channels(self) -> None:
     def channels_running(self) -> bool:
         """Are any of the channels created and running?"""
         return (
-            self.shell_channel.is_alive()
-            or self.iopub_channel.is_alive()
-            or self.stdin_channel.is_alive()
-            or self.hb_channel.is_alive()
-            or self.control_channel.is_alive()
+            (self._shell_channel and self.shell_channel.is_alive())
+            or (self._iopub_channel and self.iopub_channel.is_alive())
+            or (self._stdin_channel and self.stdin_channel.is_alive())
+            or (self._hb_channel and self.hb_channel.is_alive())
+            or (self._control_channel and self.control_channel.is_alive())
         )
 
     ioloop = None  # Overridden in subclasses that use pyzmq event loop

jupyter_client/session.py

@@ -101,15 +101,15 @@ def json_packer(obj):
             default=json_default,
             ensure_ascii=False,
             allow_nan=False,
-        ).encode("utf8")
+        ).encode("utf8", errors="surrogateescape")
     except (TypeError, ValueError) as e:
         # Fallback to trying to clean the json before serializing
         packed = json.dumps(
             json_clean(obj),
             default=json_default,
             ensure_ascii=False,
             allow_nan=False,
-        ).encode("utf8")
+        ).encode("utf8", errors="surrogateescape")
 
         warnings.warn(
             f"Message serialization failed with:\n{e}\n"