Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jupyter/jupyter_client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.3.3
Choose a base ref
...
head repository: jupyter/jupyter_client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.3.4
Choose a head ref
  • 11 commits
  • 7 files changed
  • 4 contributors

Commits on Jun 6, 2022

  1. [pre-commit.ci] pre-commit autoupdate

    updates:
    - [github.com/sirosen/check-jsonschema: 0.15.1 → 0.16.0](python-jsonschema/check-jsonschema@0.15.1...0.16.0)
    pre-commit-ci[bot] authored Jun 6, 2022
    Copy the full SHA
    bf8b115 View commit details

Commits on Jun 7, 2022

  1. Copy the full SHA
    01bfdd1 View commit details

Commits on Jun 8, 2022

  1. Copy the full SHA
    dcb4596 View commit details
  2. Copy the full SHA
    3c6fc38 View commit details
  3. ignore type error

    blink1073 committed Jun 8, 2022
    Copy the full SHA
    a2e9057 View commit details
  4. fix sphinx 5.0 support

    blink1073 committed Jun 8, 2022
    Copy the full SHA
    30ce753 View commit details
  5. Copy the full SHA
    2c54559 View commit details
  6. Copy the full SHA
    ca4cb2d View commit details
  7. Copy the full SHA
    51e071a View commit details
  8. Copy the full SHA
    fd7525d View commit details
  9. Publish 7.3.4

    SHA256 hashes:
    
    jupyter_client-7.3.4-py3-none-any.whl: 17d74b0d0a7b24f1c8c527b24fcf4607c56bee542ffe8e3418e50b21e514b621
    
    jupyter_client-7.3.4.tar.gz: aa9a6c32054b290374f95f73bb0cae91455c58dfb84f65c8591912b8f65e6d56
    github-actions[bot] committed Jun 8, 2022
    Copy the full SHA
    c26ce9f View commit details
Showing with 73 additions and 9 deletions.
  1. +37 −0 .github/workflows/downstream.yml
  2. +1 −1 .pre-commit-config.yaml
  3. +21 −2 CHANGELOG.md
  4. +1 −1 docs/conf.py
  5. +1 −1 jupyter_client/_version.py
  6. +10 −2 jupyter_client/threaded.py
  7. +2 −2 pyproject.toml
37 changes: 37 additions & 0 deletions .github/workflows/downstream.yml
Original file line number Diff line number Diff line change
@@ -79,3 +79,40 @@ jobs:
conda install -c conda-forge xeus-cling
pip install -e ".[test]"
python -m unittest -v
qtconsole:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: "3.9"
architecture: "x64"

- name: Install System Packages
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev
- name: Install qtconsole dependencies
shell: bash -l {0}
run: |
cd ${GITHUB_WORKSPACE}/..
git clone https://github.com/jupyter/qtconsole.git
cd qtconsole
${pythonLocation}/bin/python -m pip install -e ".[test]"
${pythonLocation}/bin/python -m pip install pyqt5
- name: Install Jupyter-Client changes
shell: bash -l {0}
run: ${pythonLocation}/bin/python -m pip install -e .

- name: Test qtconsole
shell: bash -l {0}
run: |
cd ${GITHUB_WORKSPACE}/../qtconsole
xvfb-run --auto-servernum ${pythonLocation}/bin/python -m pytest -x -vv -s --full-trace --color=yes qtconsole
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ repos:
args: [--max-line-length=100]

- repo: https://github.com/sirosen/check-jsonschema
rev: 0.15.1
rev: 0.16.0
hooks:
- id: check-jsonschema
name: "Check GitHub Workflows"
23 changes: 21 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,27 @@

<!-- <START NEW CHANGELOG ENTRY> -->

## 7.3.4

([Full Changelog](https://github.com/jupyter/jupyter_client/compare/v7.3.3...ca4cb2d6a4b95a6925de85a47b323d2235032c74))

### Bugs fixed

- Revert latest changes to `ThreadedZMQSocketChannel` because they break Qtconsole [#803](https://github.com/jupyter/jupyter_client/pull/803) ([@ccordoba12](https://github.com/ccordoba12))

### Maintenance and upkeep improvements

- Fix sphinx 5.0 support [#804](https://github.com/jupyter/jupyter_client/pull/804) ([@blink1073](https://github.com/blink1073))
- [pre-commit.ci] pre-commit autoupdate [#799](https://github.com/jupyter/jupyter_client/pull/799) ([@pre-commit-ci](https://github.com/pre-commit-ci))

### Contributors to this release

([GitHub contributors page for this release](https://github.com/jupyter/jupyter_client/graphs/contributors?from=2022-06-07&to=2022-06-08&type=c))

[@blink1073](https://github.com/search?q=repo%3Ajupyter%2Fjupyter_client+involves%3Ablink1073+updated%3A2022-06-07..2022-06-08&type=Issues) | [@ccordoba12](https://github.com/search?q=repo%3Ajupyter%2Fjupyter_client+involves%3Accordoba12+updated%3A2022-06-07..2022-06-08&type=Issues) | [@pre-commit-ci](https://github.com/search?q=repo%3Ajupyter%2Fjupyter_client+involves%3Apre-commit-ci+updated%3A2022-06-07..2022-06-08&type=Issues)

<!-- <END NEW CHANGELOG ENTRY> -->

## 7.3.3

([Full Changelog](https://github.com/jupyter/jupyter_client/compare/v7.3.2...37ca37d865db260e7da6fa85339be450d6fd3c3c))
@@ -16,8 +37,6 @@

[@utkonos](https://github.com/search?q=repo%3Ajupyter%2Fjupyter_client+involves%3Autkonos+updated%3A2022-06-06..2022-06-07&type=Issues)

<!-- <END NEW CHANGELOG ENTRY> -->

## 7.3.2

([Full Changelog](https://github.com/jupyter/jupyter_client/compare/v7.3.1...c81771416d9e09e0e92be799f3e8549d0db57e43))
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@
#
# This is also used if you do content translation via gettext catalogs.
# Usually you set "language" from the command line for these cases.
language = None
language = "en"

# There are two options for replacing |today|: either, you set today to some
# non-false value, then it is used:
2 changes: 1 addition & 1 deletion jupyter_client/_version.py
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
from typing import List
from typing import Union

__version__ = "7.3.3"
__version__ = "7.3.4"

# Build up version_info tuple for backwards compatibility
pattern = r'(?P<major>\d+).(?P<minor>\d+).(?P<patch>\d+)(?P<rest>.*)'
12 changes: 10 additions & 2 deletions jupyter_client/threaded.py
Original file line number Diff line number Diff line change
@@ -8,9 +8,11 @@
from threading import Event
from threading import Thread
from typing import Any
from typing import Awaitable
from typing import Dict
from typing import List
from typing import Optional
from typing import Union

import zmq
from traitlets import Instance
@@ -28,6 +30,10 @@
# during garbage collection of threads at exit


async def get_msg(msg: Awaitable) -> Union[List[bytes], List[zmq.Message]]:
return await msg


class ThreadedZMQSocketChannel(object):
"""A ZMQ socket invoking a callback in the ioloop"""

@@ -64,7 +70,7 @@ def __init__(
def setup_stream():
assert self.socket is not None
self.stream = zmqstream.ZMQStream(self.socket, self.ioloop)
self.stream.on_recv(self._handle_recv)
self.stream.on_recv(self._handle_recv) # type:ignore[arg-type]
evt.set()

assert self.ioloop is not None
@@ -108,11 +114,13 @@ def thread_send():
assert self.ioloop is not None
self.ioloop.add_callback(thread_send)

def _handle_recv(self, msg_list: List[bytes]) -> None:
def _handle_recv(self, future_msg: Awaitable) -> None:
"""Callback for stream.on_recv.
Unpacks message, and calls handlers with it.
"""
assert self.ioloop is not None
msg_list = self.ioloop._asyncio_event_loop.run_until_complete(get_msg(future_msg))
assert self.session is not None
ident, smsg = self.session.feed_identities(msg_list)
msg = self.session.deserialize(smsg)
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
name = "jupyter_client"
version = "7.3.3"
version = "7.3.4"
description = "Jupyter protocol implementation and client libraries"
keywords = [ "Interactive", "Interpreter", "Shell", "Web",]
classifiers = [
@@ -93,7 +93,7 @@ skip = ["check-links"]
ignore = [".mailmap", "*.yml", "*.yaml"]

[tool.tbump.version]
current = "7.3.3"
current = "7.3.4"
regex = '''
(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)
((?P<channel>a|b|rc|.dev)(?P<release>\d+))?