Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shareable Link doesn't work if user specified in link has his pod running #1227

Closed
manycoding opened this issue Apr 10, 2019 · 7 comments
Closed

Comments

@manycoding
Copy link
Contributor

It was fun to figure this one out:

If you copy shareable link from a shared folder:

  1. If username specified in the link has his pod (jupiter instance) running, it won’t be redirected and you will have an error:
Cannot find template: "403.html"

In "/opt/conda/share/jupyter/lab/static"
  1. Otherwise it will be redirected and opened
    A current workaround - use any name in the link except real users - e.g.
    https://jupyter.s.com/user/a/lab/tree/shared/qa/com.ipynb

The only change I did in config.yaml which might be relevant - this attached shared folder.

Helm chart version 0.8.2

@josibake
Copy link

Any suggestions on where to start for fixing this? I have a shared volume attached on my JupyterHub instance and allowing users to link to shared notebooks would be awesome. Having a user manually edit the link each time seems like a pretty bad experience

@josibake
Copy link

Looks like this is solved in JupyterLab 2.0 : jupyterlab/jupyterlab#7906. Is it possible to specify jupyterlab 2.0 when deploying my helm chart in my values.yaml? or is this a change that needs to be made upstream ?

@manics
Copy link
Member

manics commented Mar 18, 2020

@josibake JupyterLab is part of the single-user image. Z2JH bundles a minimal one, but you'll most likely want to specify your own. Are you using the default one at the moment?

@manics
Copy link
Member

manics commented Mar 18, 2020

There's some docs on https://zero-to-jupyterhub.readthedocs.io/en/latest/customizing/user-environment.html
For example you could write your own Dockerfile using one of the standard images mentioned in that link and upgrade JupyterLab, as well as installing any other custom packages.

@josibake
Copy link

thanks @manics ! I was struggling to find where to update JupyterLab (think it was in hub). I am using a custom single-user image , so this is perfect.

@manycoding
Copy link
Contributor Author

Solved in jupyterlab/jupyterlab#7906

@manics
Copy link
Member

manics commented Mar 19, 2020

Thanks for updating the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants