Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Release workflow does not publish the Python packages #113

Open
jtpio opened this issue Feb 21, 2024 · 4 comments
Open

Publish Release workflow does not publish the Python packages #113

jtpio opened this issue Feb 21, 2024 · 4 comments

Comments

@jtpio
Copy link
Member

jtpio commented Feb 21, 2024

Running the "Publish Release" workflow for 1.0.0 published the packages to npm:

image

But it didn't publish the packages to PyPI:

https://github.com/jupyterlab-contrib/jupyterlab-topbar/actions/runs/7991656309/job/21823326631

image

@jtpio
Copy link
Member Author

jtpio commented Feb 21, 2024

The Python packages have been published manually for now:

image

@mahendrapaipuri
Copy link
Collaborator

@jtpio Cheers for publishing! I am not quite sure why it didnt publish to PyPI. jupyter-releaser is using trusted publishers, right?! Did we configure the extensions on PyPI to use the current repository for publishing?

The screenshot you posted is using API token if I am right. I think we need to configure this on PyPI to use trusted publishers for jupyter-releaser to publish. Does it make sense?

@mahendrapaipuri
Copy link
Collaborator

@jtpio I think its because of Python package names. Created #117

@jtpio
Copy link
Member Author

jtpio commented Feb 22, 2024

Did we configure the extensions on PyPI to use the current repository for publishing?

Yes, they were configured as part of #110:

image

The screenshot above was to show that the release was done manually (and indeed using an API token).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants