Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of topbar items #116

Open
on46zohu opened this issue Feb 21, 2024 · 6 comments
Open

Location of topbar items #116

on46zohu opened this issue Feb 21, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@on46zohu
Copy link

on46zohu commented Feb 21, 2024

Hi. As mentioned in the description, I have a problem with how the topbar icons are located.

As you can see in the screenshot below, both items seem next to each other, which is visually disturbing.

I tried to drag them as shown here: https://github.com/jtpio/jupyterlab-topbar, but it is not responding.

You can also see my JupyterLab and extension versions.
ss

Am I missing something?

@on46zohu on46zohu added the bug Something isn't working label Feb 21, 2024
@jtpio
Copy link
Member

jtpio commented Feb 21, 2024

Thanks @on46zohu.

Yes these changes are because the topbar extensions now use the API exposed by JupyterLab directly for adding widgets to the top bar.

So there is no drag and drop to reposition them anymore. However it's possible to edit the settings to switch the order of the items via the setting editor:

jupyterlab-topbar-items-position.webm

There is also no "separator" anymore, but this could be added either via an extension, or maybe via custom CSS: https://jupyterlab.readthedocs.io/en/latest/user/custom_css.html

@on46zohu
Copy link
Author

Thanks a lot for the quick response. I tried the same, but the order/locations of the items can be only edited in the restricted area below:
image
Could you please show the jupyter labextension list output of the environment in your video?

@jtpio
Copy link
Member

jtpio commented Feb 22, 2024

@on46zohu maybe you have other (maybe older) extensions installed, that were automatically picked up?

On this test setup it was:

JupyterLab v4.1.0
/home/user/micromamba/envs/tmp/share/jupyter/labextensions
        jupyterlab-theme-toggler v1.0.0 enabled OK (python, jupyterlab_theme_toggler)
        jupyterlab-topbar-text v1.0.0 enabled OK (python, jupyterlab_topbar_text)
        jupyterlab_pygments v0.3.0 enabled OK (python, jupyterlab_pygments)
        @jupyter-notebook/lab-extension v7.1.0 enabled OK

@on46zohu
Copy link
Author

I've noticed it was not due to other extensions, but the number and rank of "spacer toolbars". After I set correct rank for each spacer between top bar elements, I could achieve the below view:
image

Thanks a lot again!

@jtpio
Copy link
Member

jtpio commented Feb 22, 2024

Nice thanks!

Thinking such information could be useful to other users too. Would you like to open a PR to document how to re-order items (via the Settings editor) in the README? Thanks!

@on46zohu
Copy link
Author

Hi again, sorry for the late response. Of course, I'd like to contribute, but never opened a PR. Could you briefly tell what I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants